fix(choice): return &Choice instead of cloning

src/pickers.rs

@@ -12,7 +12,7 @@ Required trait for Pickers. A Picker is given a slice of choices and a query tha
 Implementations of `pick` must return `Some(Choice)` for the `Choice` that was picked, or `None`.
  */
 pub trait Picker: std::fmt::Debug + Sync + Send {
-    fn pick(&self, _choices: &[Choice], _utilities: &Query<&Score>) -> Option<Choice>;
+    fn pick<'a>(&self, choices: &'a [Choice], scores: &Query<&Score>) -> Option<&'a Choice>;
 }
 
 /**
@@ -38,11 +38,11 @@ impl FirstToScore {
 }
 
 impl Picker for FirstToScore {
-    fn pick(&self, choices: &[Choice], scores: &Query<&Score>) -> Option<Choice> {
+    fn pick<'a>(&self, choices: &'a [Choice], scores: &Query<&Score>) -> Option<&'a Choice> {
         for choice in choices {
             let value = choice.calculate(scores);
             if value >= self.threshold {
-                return Some(choice.clone());
+                return Some(choice);
             }
         }
         None

src/thinker.rs

@@ -241,13 +241,8 @@ pub fn thinker_system(
                     // Think about what action we're supposed to be taking. We do this
                     // every tick, because we might change our mind.
                     // ...and then execute it (details below).
-                    exec_picked_action(
-                        &mut cmd,
-                        *actor,
-                        &mut thinker,
-                        &choice.action,
-                        &mut action_states,
-                    );
+                    let action = choice.action.clone();
+                    exec_picked_action(&mut cmd, *actor, &mut thinker, &action, &mut action_states);
                 } else if let Some(default_action_ent) = &thinker.otherwise {
                     // Otherwise, let's just execute the default one! (if it's there)
                     let default_action_ent = default_action_ent.clone();